platformioPackages: move packages inside to top-level#437191
Merged
wolfgangwalther merged 1 commit intoNixOS:masterfrom Sep 4, 2025
Merged
platformioPackages: move packages inside to top-level#437191wolfgangwalther merged 1 commit intoNixOS:masterfrom
wolfgangwalther merged 1 commit intoNixOS:masterfrom
Conversation
nixpkgs-ci
bot
added
10.rebuild-darwin: 0
13 tasks
nixpkgs-ci
bot
added
the
9.needs: reviewer
Contributor
wolfgangwalther
left a comment
wolfgangwalther
left a comment
There was a problem hiding this comment.
These packages are already built as well, because they are exposed as top-level attributes, too.
This looks to me like a case where the logic here should maybe be moved inside the package's file instead and then a simple inherit (callPackage ...) platformio platformio-core; should be done?
I don't understand why platformioPackages is explicitly exposed for nixos search, though.
nixpkgs-ci
bot
removed
the
9.needs: reviewer
SuperSandro2000
approved these changes
Aug 27, 2025
nixpkgs-ci
bot
added
12.approvals: 1
jopejoe1
force-pushed
the
eval-platformio
branch
from
27a3bec to
50d252a
Compare
nixpkgs-ci
bot
removed
the
2.status: merge conflict
nixpkgs-ci
bot
added
the
2.status: merge conflict
jopejoe1
force-pushed
the
eval-platformio
branch
from
50d252a to
d7f8aa9
Compare
nixpkgs-ci
bot
removed
the
2.status: merge conflict
jopejoe1
force-pushed
the
eval-platformio
branch
from
d7f8aa9 to
e3ca3fd
Compare
wolfgangwalther
approved these changes
Sep 4, 2025
wolfgangwalther
changed the title
nixpkgs-ci
bot
added
12.approvals: 2
jopejoe1
force-pushed
the
eval-platformio
branch
from
e3ca3fd to
2e074e6
Compare
nixpkgs-ci
bot
removed
the
2.status: merge conflict
SuperSandro2000
approved these changes
Sep 4, 2025
This comment was marked as resolved.
This comment was marked as resolved.
wolfgangwalther
added
the
8.has: port to stable
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split from #434501
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.